Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files Not Recognized #190

Closed
TinfoilSubmarine opened this issue May 27, 2016 · 3 comments
Closed

Files Not Recognized #190

TinfoilSubmarine opened this issue May 27, 2016 · 3 comments

Comments

@TinfoilSubmarine
Copy link

When a file has an extension with capital letters (examples: .JPG, .Jpg, .jPg, etc.) the file is not recognized by LeafPic.

@JunCTionS
Copy link

Ah you're right! I thought it might be some weird issue with SD permissions in my case, I'm happy this is the case as it is easier (I'm seeing this in a folder with many .JPG images downloaded from my camera and the occasional .jpg edited on the phone).
I don't have the proper setup to do a pull request, but I guess this would be fixed by changing:
LeafPic/app/src/main/java/com/horaapps/leafpic/Base/ImageFileFilter.java
where it says:
if (filename.endsWith(extension))
to:
if (filename.toLowerCase().endsWith(extension))

@dnldsht
Copy link
Member

dnldsht commented May 29, 2016

Done, will be available in the next release!
Stay tuned

On Sun, May 29, 2016, 1:27 PM JunCTionS [email protected] wrote:

Ah you're right! I thought it might be some weird issue with SD
permissions in my case, I'm happy this is the case as it is easier (I'm
seeing this in a folder with many .JPG images downloaded from my camera and
the occasional .jpg edited on the phone).
I don't have the proper setup to do a pull request, but I guess this would
be fixed by changing:
LeafPic/app/src/main/java/com/horaapps/leafpic/Base/ImageFileFilter.java
where it says:

if (filename.endsWith(extension))
to:
if (filename.toLowerCase().endsWith(extension))


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#190 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFBzAGL7hAof31Q6xXefqllk0VQdyXTqks5qGXgWgaJpZM4IoGZP
.

@dnldsht
Copy link
Member

dnldsht commented Jun 16, 2016

fixed with this release

@dnldsht dnldsht closed this as completed Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants