Restore 2.3.1 version check #1696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This re-adds a variant of the UndertaleAnimationCurve version check into UndertaleAnimationCurve.cs itself. (It had previously been moved to UndertaleChunks.cs to match most other chunk-parsing-based version checks.) This is because at least one game-- TS!Underswap, Demo v1.0, makes use of embedded animation curves in its sequences, which are parsed prior to the ACRV check in UndertaleChunks. Closes #1414.
Caveats
The check is imperfect, but it loads the demo in question correctly. Marking this as draft as it does cause a mismatch in object count unserialization and an associated warning.
Notes
There's definitely a possibility for the check yielding false positives or negatives, but we had it for a long time back in the day and evidently got no complaints or it would have changed more than just being moved as an optimization measure.
Also, I am amenable to re-removing the check from UndertaleChunks, as this may make that check redundant.