Add global grid width, height and thickness settings #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
|
The room grid settings should be separated, as it done with a profile mode settings - add |
|
Addressed those |
|
You didn't properly aligned the check boxes and their labels - you should add |
Miepee
force-pushed
the
roomglobal
branch
2 times, most recently
from
058f831 to
2fac37c
Compare
Co-Authored-By: plrusek <[email protected]>
VladiStep
requested changes
Jun 27, 2022
Miepee
force-pushed
the
roomglobal
branch
2 times, most recently
from
ec3870d to
2090d82
Compare
VladiStep
reviewed
Jun 27, 2022
VladiStep
reviewed
Jun 27, 2022
VladiStep
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds global room grid width, height and thickness settings, which override the automatically calculated grid width / height and hardcoded grid thickness.
Caveats
None
Notes
This is Change 2 of #931.