Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors out on Deltarune (AUDO chunk) #33

Closed
NarryG opened this issue Oct 31, 2018 · 5 comments
Closed

Errors out on Deltarune (AUDO chunk) #33

NarryG opened this issue Oct 31, 2018 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@NarryG
Copy link

NarryG commented Oct 31, 2018

Time to dig. https://www.deltarune.com/

Throws an error on the sound chunk
image
@krzys-h
Copy link
Member

krzys-h commented Oct 31, 2018

Already noticed!

https://www.reddit.com/r/Underminers/comments/9syjq6/survey_program_windows_englishexe/e8sjni4

Probably related to the existence of audiogroups1.dat

(if you do anything with this, please remenber about the no spoilers for 24h rule)

@krzys-h krzys-h added bug Something isn't working help wanted Extra attention is needed labels Oct 31, 2018
@NarryG
Copy link
Author

NarryG commented Oct 31, 2018 •
edited
Loading

Yeah I know. I bypassed it for now and I'm only bringing stuff up in the speedrunning community in the spoilers channel.

@PoroCYon
Copy link
Contributor

PoroCYon commented Oct 31, 2018 •
edited
Loading

Works with Altar.NET, so it's not really related, as Altar.NET doesn't even know about GMS2. (I disabled disassembling/decompiling, of course.)

About audiogroups1.dat: d579374c.

EDIT: I've looked at the source, but the code jumps through >5 files, making it hard to track what exactly is going on :/

It looks like the number from the cache would be wrong (as the 56 is what's in the file), but I don't know if this is even true, or how it could happen.

@krzys-h
Copy link
Member

krzys-h commented Oct 31, 2018

@PoroCYon UndertaleModTool in general tries to resolve these numeric IDs to actual objects and that fails because it doesn't see the stuff that should come from audiogroups1.dat

krzys-h added a commit that referenced this issue Nov 1, 2018
@krzys-h
Make resource ID errors less critical
df6f5b5 
This is probably not related in any way to any surveys you might have
come across recently

Related: #33
@krzys-h
Copy link
Member

krzys-h commented Nov 1, 2018

Preliminary support implemented in de5279d

@krzys-h krzys-h closed this as completed Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krzys-h @NarryG @PoroCYon