Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Реализация setCustomReaderParams #2

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Реализация setCustomReaderParams #2

wants to merge 8 commits into from

Conversation

mikekosulin
Copy link

@mikekosulin mikekosulin commented Sep 16, 2023 •
edited
Loading

Настройка для автоматического включения NFC на ридере P17 при проведении транзакции

  • Android
  • iOS

DCrow
DCrow requested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@DCrow DCrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за доработку!

Оставил замечания к PR.
Также остался вопрос насчет форматирования. Это с использованием dart format ?

android/src/main/kotlin/com/unact/iboxpro_flutter/IboxproFlutterHandlerImpl.kt Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
lib/src/payment.dart Outdated Show resolved Hide resolved
example/android/settings.gradle Outdated Show resolved Hide resolved
@mikekosulin
Copy link
Author

Оставил замечания к PR.

Окей, поправлю в течение недели, как будет время.

Также остался вопрос насчет форматирования. Это с использованием dart format ?

Да, через VSCode, могу без автоформатирования закоммитить

@DCrow
Copy link
Contributor

DCrow commented Dec 14, 2023

Да, через VSCode, могу без автоформатирования закоммитить

Да, лучше без него. У dart format довольно специфическое форматирование, иногда читать наоборот становится хуже.

@mikekosulin mikekosulin marked this pull request as draft December 18, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DCrow DCrow DCrow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikekosulin @DCrow