5.2.1 Changes #38
Open
5.2.1 Changes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c2d883c.
kushagrag
approved these changes
Dec 14, 2023
debdeep-ganguly
suggested changes
Dec 18, 2023
| }; | ||
| forceReload = () => { | ||
| if (Platform.OS === 'ios') { | ||
| // TODO iOS |
There was a problem hiding this comment.
force-reload in iOS handling not needed here?
|
|
||
| if (!uri) { | ||
| if (!uri) { | ||
| console.warn('Trying to load empty source.'); |
There was a problem hiding this comment.
should we do error handling in an UI when uri is invalid?
| @@ -39,14 +46,19 @@ public final class ExoPlayerView extends FrameLayout { | |||
| private SimpleExoPlayer player; | |||
There was a problem hiding this comment.
Are we sure that we want to move ahead with the deprecated version of Exoplayer - v2, instead of using the Exoplayer from android.media3? Last version supported will be v2.19.0.
| } | ||
| } | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
replace all e.printStackTrace() usages with Log.d, since it shows up on prod
| && currentPos != null | ||
| && playBackState == Player.STATE_READY | ||
| && playWhenReady) { | ||
| Format videoFormat = player.getVideoFormat(); |
There was a problem hiding this comment.
Does player.getVideoFormat() not needed to be called from player's thread?
| int bitrate = videoFormat != null ? videoFormat.bitrate : 0; | ||
|
|
||
| long pos = currentPos; | ||
| long bufferedDuration = player.getBufferedPercentage() * duration / 100; |
| @@ -110,7 +122,7 @@ class ReactExoplayerView extends FrameLayout implements | |||
| private ExoPlayerView exoPlayerView; | |||
|
|
|||
| private DataSource.Factory mediaDataSourceFactory; | |||
| private SimpleExoPlayer player; | |||
| private volatile SimpleExoPlayer player; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.