few improvements #12
Merged
few improvements #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line 18-21 on Windows, this pull request introduces new functionality. It checks if the user is inactive (no mouse/keyboard usage) and if so, it goes to sleep. I use it, as quite often I fall asleep or leave, and the less prolific's API is used, the less it costs, the less likely they will ban us/or disable it - line 120 it works as it is. It goes straight to the study, therefore there is no # TODO - line 145-170 script pausing functionality implementation. Most likely this is impossible to get done under PyAutoGui, as it's too dumb, I checked. Shame, as PyAutoGui would make it cross platform (Linux, Mac) lines 162-167 unnecessary lines 191-204 implementation of script sleeping on the Windows platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lines 18-21 --- on Windows, this pull request introduces new functionality. It checks if the user is inactive (no mouse/keyboard usage) and if so, it goes to sleep. I use it, as quite often I fall asleep or leave, and the less prolific's API is used, the less it costs, the less likely they will ban us/or disable it
line 120 --- it works as it is. It goes straight to the study, therefore there is no # TODO
lines 145-170 --- script pausing functionality implementation. Most likely this is impossible to get done under PyAutoGui, as it's too dumb, I checked. Shame, as PyAutoGui would make it cross platform (Linux, Mac)
lines 162-167 --- unnecessary
lines 191-204 --- implementation of script sleeping on the Windows platform