Change Syntax Highlighting plugin to fast-syntax-highlighting #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-Sy-H is a far better alternative to zsh-syntax-highlighting. It has not only better syntax highlighting, but it is mush less buggy.
|
These changes might be better fit for a later verion of Ultramarine. |
lleyton
reviewed
Mar 30, 2024
| @@ -12,7 +12,7 @@ Source3: ultramarine-shell.sh | |||
| Source4: starship.toml | |||
|
|
|||
| Requires: zsh-autosuggestions | |||
| Requires: zsh-syntax-highlighting | |||
| Requires: F-Sy-H | |||
There was a problem hiding this comment.
I don't think F-Sy-H is packaged in Fedora or Terra, is it?
There was a problem hiding this comment.
It would need to be packaged, then. I don't know how to do that, but I assume that it is easy to do for shell plugins.
|
Yeah, I don't feel comfortable including this plugin considering the sketchiness around the author. See: https://www.youtube.com/watch?v=pHVbjLTFmVo If you have another option, please let me know. |
|
|
|
Looks good with me, package it for Terra and we can ship that |
|
Alright, great. |
VehementHam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F-Sy-H is a far better alternative to zsh-syntax-highlighting. It has not only better syntax highlighting, but it is mush less buggy.