Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Surface images #48

Open
wants to merge 10 commits into
base: um41
Choose a base branch
from
Open

Add Surface images #48

wants to merge 10 commits into from

Conversation

nothingneko
Copy link
Contributor

No description provided.

@nothingneko nothingneko marked this pull request as draft October 1, 2024 14:01
@nothingneko nothingneko mentioned this pull request Oct 1, 2024
Closed
@nothingneko
Copy link
Contributor Author

workaround didn't work

we need to wait for surface kernel to fix 41

@nothingneko
Update branch
235507a 
Merge from upstream
@nothingneko
Copy link
Contributor Author

nothingneko commented Oct 9, 2024 •
edited
Loading

TODO

  • remove Surface aarch builds
  • wait on upstream to fix F41
  • Presets file @Owen-sz

@Owen-sz
Copy link
Collaborator

Owen-sz commented Oct 26, 2024

Ultramarine-Linux/packages#87

@Owen-sz
Copy link
Collaborator

Owen-sz commented Oct 27, 2024

Note (to myself as well):

  • surface-dtx-daemon
  • ultramarine-release-surface
  • ultramarine-release-identity-surface

Probably

@nothingneko @Owen-sz
Update surface.yaml
8e5631f 
Co-authored-by: Owen Zimmerman <[email protected]>
@Owen-sz
Copy link
Collaborator

Owen-sz commented Oct 30, 2024

Note (to myself as well):

* surface-dtx-daemon

* ultramarine-release-surface

* ultramarine-release-identity-surface

Probably

Shouldn't need identity, good to go now.

@nothingneko nothingneko marked this pull request as ready for review October 30, 2024 01:18
june-fish
june-fish requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@june-fish june-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should exclude the standard kernel for images using the surface kernel, look at how this was one for chromebooks for reference.

@nothingneko
Copy link
Contributor Author

You should exclude the standard kernel for images using the surface kernel, look at how this was one for chromebooks for reference.

I swear I already did this

Owen-sz
Owen-sz previously approved these changes Oct 30, 2024
View reviewed changes
Owen-sz
Owen-sz previously approved these changes Oct 31, 2024
View reviewed changes
june-fish
june-fish previously approved these changes Oct 31, 2024
View reviewed changes
madonuko
madonuko previously approved these changes Nov 1, 2024
View reviewed changes
@madonuko madonuko dismissed stale reviews from june-fish and themself via c688f9f November 9, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Owen-sz Owen-sz Owen-sz approved these changes

@june-fish june-fish june-fish left review comments

@lleyton lleyton Awaiting requested review from lleyton

@madonuko madonuko Awaiting requested review from madonuko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nothingneko @Owen-sz @madonuko @june-fish