Fix Tree-support lines overlapping with the model #2088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: Community Contribution 👑
nallath
approved these changes
Jul 5, 2024
|
Already merged :) |
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Ultimaker/Cura#18970 by keeping holes if they overlap with the model.
Technically this does cause floating lines, but that is in my opinion better than the alternative.
There could be an argument made to only apply this if the
support densityis > 0%, but I do not know if there could be other issues caused by model areas being inside of a support area.Type of change
How Has This Been Tested?
Test Configuration:
Checklist: