Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Advanced Cooling Fan Control' post-processing script. #17926

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

rburema
Copy link
Member

@rburema rburema commented Jan 7, 2024

See discussions in #15853 (which was closed, for which this is a replacement) and (internally) tracking-ticket CURA-11520.

See discussions in #15853 (on github) and (internally) tracking-ticket CURA-11520
@rburema
Copy link
Member Author

rburema commented Jan 7, 2024

There was a little bug where if you added this post-script, then switched printers, and then added this post-script to the other printer as well, Cura would crash. It was easy to fix, so I did that.

The other code is unchanged from what @GregValiant sent me in the final discussion in #15853

@rburema rburema merged commit 8676cc3 into main Jan 7, 2024
8 checks passed
@rburema rburema deleted the CURA-11520_add_fancontrol_post branch January 7, 2024 11:52
@rburema
Copy link
Member Author

rburema commented Jan 7, 2024

@GregValiant Just to be sure: I never mean the comments I write as 'do this or else'. No matter how terse they are, there is almost always rooms for discussion.

(By the way; I'm also reducing the number of hours I work at UM, and I still have to discuss with my leads/colleagues what that means for how much time I'll spend publicly working on things like community PR's and the like.)

In any cases, best whishes' for the new year!

@GregValiant
Copy link
Collaborator

GregValiant commented Jan 9, 2024

@rburema
Did you get the latest and greatest from my last post in #15853 ? I had made changes that included adding more "lists" as you had requested. I also fixed a minor bug in the regex replacements.
I see that crash now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants