11-17 role audit (#1245)

Went through every Village-aligned role from Watcher to Funsmith. Mostly
bugfixes or extra flavor text. A few new albeit basic roles for the
other alignment rosters

---------

Co-authored-by: ammico <[email protected]>
Co-authored-by: ultimafia-bot <[email protected]>

Games/types/Mafia/const/Priority.js

@@ -13,7 +13,7 @@ const PRIORITY_UNTARGETABLE = -180;
 const PRIORITY_MODIFY_ACTION_LABELS = -120;
 
 const PRIORITY_REDIRECT_ACTION = -110;
-const PRIORITY_STEAL_ACTIONS = -105;
+const PRIORITY_COPY_ACTIONS = -105;
 const PRIORITY_SWAP_VISITORS = -104;
 
 const PRIORITY_CANCEL_ROLEBLOCK_ACTIONS = -100;
@@ -85,7 +85,7 @@ module.exports = {
   PRIORITY_MODIFY_ACTION_DELAY,
 
   PRIORITY_REDIRECT_ACTION,
-  PRIORITY_STEAL_ACTIONS,
+  PRIORITY_COPY_ACTIONS,
   PRIORITY_SWAP_VISITORS,
 
   PRIORITY_CANCEL_ROLEBLOCK_ACTIONS,

Games/types/Mafia/items/Armor.js

@@ -8,9 +8,13 @@ module.exports = class Armor extends Item {
     // if armour starts out cursed, the setter will handle the logic of making it cursed
     this.cursedUses = 0;
     this.optionCursed = options?.cursed;
+    //this.cultUses = 1
+    //this.optionCult = options?.cult
 
     this.listeners = {
       immune: function (action, player) {
+        let killer = this.getVisitors(this.target, "kill");
+
         if (player == this.holder && action.hasLabel("kill")) {
           if (this.holder.tempImmunity["kill"]) return;
 
@@ -25,13 +29,16 @@ module.exports = class Armor extends Item {
             }
           }
 
-          this.uses--;
+        this.uses--;
           this.holder.queueAlert(
             ":armor: Shattering to pieces, your armor saves your life!"
           );
 
           if (this.uses <= 0) {
             this.removeEffectsIfNeeded();
+            /*if (this.cultUses <= 0) {
+              this.killer.giveEffect("Insanity", this.holder);
+            }*/
             if (this.cursedUses <= 0) {
               this.drop();
             }
@@ -72,12 +79,14 @@ module.exports = class Armor extends Item {
       if (item.name == "Armor") {
         item.uses += this.uses;
         item.cursedUses += this.cursedUses;
+        //item.cultUses += this.cultUses;
         item.applyEffectsIfNeeded();
         return;
       }
     }
 
     super.hold(player);
     this.cursed = this.optionCursed;
+    //this.cult = this.optionCult;
   }
 };

Games/types/Mafia/roles/Cult/Ghoul.js

@@ -0,0 +1,14 @@
+const Role = require("../../Role");
+
+module.exports = class Ghoul extends Role {
+  constructor(player, data) {
+    super("Ghoul", player, data);
+    this.alignment = "Cult";
+    this.cards = [
+      "VillageCore",
+      "WinWithCult",
+      "MeetingCult",
+      "CopyActions",
+    ];
+  }
+};

Games/types/Mafia/roles/Cult/Ritualist.js

@@ -0,0 +1,15 @@
+const Role = require("../../Role");
+
+module.exports = class Ritualist extends Role {
+  constructor(player, data) {
+    super("Ritualist", player, data);
+
+    this.alignment = "Cult";
+    this.cards = [
+      "VillageCore",
+      "WinWithCult",
+      "MeetingCult",
+      "Sacrifice",
+    ];
+  }
+};

Games/types/Mafia/roles/Cult/Shadow.js

@@ -0,0 +1,14 @@
+const Role = require("../../Role");
+
+module.exports = class Shadow extends Role {
+  constructor(player, data) {
+    super("Shadow", player, data);
+    this.alignment = "Cult";
+    this.cards = [
+      "VillageCore",
+      "WinWithCult",
+      "MeetingCult",
+      "TrackAndWatchPlayer",
+    ];
+  }
+};

Games/types/Mafia/roles/Hostile/Tofurkey.js

@@ -13,5 +13,12 @@ module.exports = class Tofurkey extends Role {
       "FamineImmune",
       "WinIfOnlyTurkeyAlive",
     ];
+    this.appearance = {
+      self: "real",
+      reveal: "Turkey",
+      condemn: "real",
+      death: "real",
+      investigate: "Turkey",
+    };
   }
 };

Games/types/Mafia/roles/Mafia/Ape.js

@@ -0,0 +1,14 @@
+const Role = require("../../Role");
+
+module.exports = class Ape extends Role {
+  constructor(player, data) {
+    super("Ape", player, data);
+    this.alignment = "Mafia";
+    this.cards = [
+      "VillageCore",
+      "WinWithMafia",
+      "MeetingMafia",
+      "CopyActions",
+    ];
+  }
+};

Games/types/Mafia/roles/Mafia/Don.js

@@ -0,0 +1,15 @@
+const Role = require("../../Role");
+
+module.exports = class Don extends Role {
+  constructor(player, data) {
+    super("Don", player, data);
+
+    this.alignment = "Mafia";
+    this.cards = [
+      "VillageCore",
+      "WinWithMafia",
+      "MeetingMafia",
+      "OverturnVote",
+    ];
+  }
+};

Games/types/Mafia/roles/Mafia/Santista.js

@@ -0,0 +1,15 @@
+const Role = require("../../Role");
+const { PRIORITY_MAFIA_KILL } = require("../../const/Priority");
+
+module.exports = class Santista extends Role {
+  constructor(player, data) {
+    super("Santista", player, data);
+    this.alignment = "Mafia";
+    this.cards = [
+      "VillageCore",
+      "WinWithMafia",
+      "MeetingMafia",
+      "MeetWithMasons",
+    ];
+  }
+};

Games/types/Mafia/roles/Village/Apothecary.js

@@ -0,0 +1,15 @@
+const Role = require("../../Role");
+
+module.exports = class Apothecary extends Role {
+  constructor(player, data) {
+    super("Apothecary", player, data);
+
+    this.alignment = "Village";
+    this.cards = [
+      "VillageCore",
+      "WinWithVillage",
+      "CleanseVisitors",
+    ];
+    this.immunity.wolfBite = 1;
+  }
+};

Games/types/Mafia/roles/Village/Blacksmith.js

@@ -5,6 +5,6 @@ module.exports = class Blacksmith extends Role {
     super("Blacksmith", player, data);
 
     this.alignment = "Village";
-    this.cards = ["VillageCore", "WinWithVillage", "ArmorGiver"];
+    this.cards = ["VillageCore", "WinWithVillage", "GiveArmor"];
   }
 };

Games/types/Mafia/roles/Village/Miller.js

@@ -5,6 +5,6 @@ module.exports = class Miller extends Role {
     super("Miller", player, data);
 
     this.alignment = "Village";
-    this.cards = ["VillageCore", "WinWithVillage", "GuiltyAppearance"];
+    this.cards = ["VillageCore", "WinWithVillage", "AppearAsMafioso"];
   }
 };

Games/types/Mafia/roles/Village/Monkey.js

@@ -5,6 +5,14 @@ module.exports = class Monkey extends Role {
     super("Monkey", player, data);
 
     this.alignment = "Village";
-    this.cards = ["VillageCore", "WinWithVillage", "StealActions"];
+    this.cards = ["VillageCore", "WinWithVillage", "CopyActions"];
+    this.meetingMods = {
+      Copy: {
+        actionName: "Monkey See",
+      },
+      Imitate: {
+        actionName: "Monkey Do",
+      },
+    };
   }
 };

Games/types/Mafia/roles/Independent/Occultist.js → Games/types/Mafia/roles/Village/Occultist.js

@@ -4,8 +4,7 @@ module.exports = class Occultist extends Role {
   constructor(player, data) {
     super("Occultist", player, data);
 
-    this.alignment = "Independent";
-    this.winCount = "Village";
-    this.cards = ["VillageCore", "WinWithCult", "Oblivious"];
+    this.alignment = "Village";
+    this.cards = ["VillageCore", "WinWithVillage", "AppearAsCultist"];
   }
 };

Games/types/Mafia/roles/Village/Priest.js

@@ -9,10 +9,6 @@ module.exports = class Priest extends Role {
       "VillageCore",
       "WinWithVillage",
       "LearnVisitorsRole",
-      "CleanseLycanVisitors",
-      "CureAlcoholicVisitors",
-      "KillWerewolfVisitors",
-      "ConvertKillersOnDeath",
     ];
     this.immunity.wolfBite = 1;
   }

Games/types/Mafia/roles/Village/Monitor.js → Games/types/Mafia/roles/Village/Voyeur.js

@@ -1,8 +1,8 @@
 const Role = require("../../Role");
 
-module.exports = class Monitor extends Role {
+module.exports = class Voyeur extends Role {
   constructor(player, data) {
-    super("Monitor", player, data);
+    super("Voyeur", player, data);
 
     this.alignment = "Village";
     this.cards = ["VillageCore", "WinWithVillage", "WatchPlayerRole"];

Games/types/Mafia/roles/cards/AppearAsCultist.js

@@ -0,0 +1,22 @@
+const Card = require("../../Card");
+
+module.exports = class AppearAsCultist extends Card {
+  constructor(role) {
+    super(role);
+
+    const selfAppearance = role.name == "Occultist" ? "Villager" : "real";
+
+    this.appearance = {
+      self: selfAppearance,
+      reveal: "real",
+      condemn: "Cultist",
+      death: "real",
+      investigate: "Cultist",
+    };
+
+    this.hideModifier = {
+      condemn: true,
+      investigate: true,
+    };
+  }
+};

Games/types/Mafia/roles/cards/GuiltyAppearance.js → Games/types/Mafia/roles/cards/AppearAsMafioso.js

@@ -1,6 +1,6 @@
 const Card = require("../../Card");
 
-module.exports = class GuiltyAppearance extends Card {
+module.exports = class AppearAsMafioso extends Card {
   constructor(role) {
     super(role);