Add staticcheck to actions #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will move regex out of the loop
elivlo
force-pushed
the
fix-use-regexp-compile-and-staticcheck
branch
2 times, most recently
from
0cee179 to
a4b17cc
Compare
elivlo
force-pushed
the
fix-use-regexp-compile-and-staticcheck
branch
from
a4b17cc to
42200c1
Compare
|
Hi @Ullaakut :) |
Ullaakut
reviewed
May 11, 2022
Comment on lines
+70
to
+71
| interfaceRegex := regexp.MustCompile(`\*INTERFACES\*`) | ||
| routesRegex := regexp.MustCompile(`\*ROUTES\*`) |
There was a problem hiding this comment.
Usually regexp.MustCompile statements are kept outside of the function body, in var declarations at the top of the files they are used in. WDYT?
See discussion about it in the noglobals linter if you're curious
There was a problem hiding this comment.
I will change this. @ChnMig mentioned it but I was not sure if we really need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will apply some changes to actions. It will add staticcheck to check the code for some optimization.
Suggestion from: #95