Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misunderstanding between Configuration and Confidence #84

Closed
mxrch opened this issue Jul 13, 2021 · 2 comments
Closed

Misunderstanding between Configuration and Confidence #84

mxrch opened this issue Jul 13, 2021 · 2 comments

Comments

@mxrch
Copy link
Contributor

mxrch commented Jul 13, 2021

I think you interpreted the "conf" nmap parameter as "Configuration" while it means "Confidence".
The attribute : https://pkg.go.dev/github.com/Ullaakut/nmap/v2#Service.Configuration
Nmap documentation : https://nmap.org/book/output-formats-xml-output.html#output-formats-xml-port-elements

I'll provide a PR !
mxrch added a commit to mxrch/nmap that referenced this issue Jul 13, 2021
@mxrch
fix misunderstanding between Configuration and Confidence (Ullaakut#84)
062dd5b
@mxrch mxrch mentioned this issue Jul 13, 2021
Merged
@mxrch
Copy link
Contributor Author

mxrch commented Jul 13, 2021

Here is the PR ! #85

@Ullaakut
Copy link
Owner

Hi @mxrch ! Thank you very much :) That indeed seems to be the case. Great catch!

Ullaakut pushed a commit that referenced this issue Jul 13, 2021
@mxrch
fix misunderstanding between Configuration and Confidence (#84) (#85)
c87bc07
@mxrch mxrch closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ullaakut @mxrch