Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests UGN-272 add column matching tests #73

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Tests UGN-272 add column matching tests #73

merged 2 commits into from
Mar 16, 2022

Conversation

masiulis
Copy link
Contributor

  • added tests for column matching step

@masiulis masiulis requested a review from JulitorK March 16, 2022 16:05
@linear
Copy link

linear bot commented Mar 16, 2022

{ name: data[1][0], is_cool: true },
{ name: data[2][0], is_cool: false },
{ name: data[3][0], is_cool: false },
{ name: data[4][0], is_cool: false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That autoconversion is ruthless, sorry Kanye.

Copy link
Contributor

@JulitorK JulitorK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!

@masiulis masiulis merged commit 876ec71 into master Mar 16, 2022
@masiulis masiulis deleted the UGN-272 branch March 16, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants