[243] fix error name and msg

UffizziCloud · Jul 24, 2023 · fcaf94c · fcaf94c
1 parent ba2d34f
commit fcaf94c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/uffizzi/services/kubeconfig_service.rb b/lib/uffizzi/services/kubeconfig_service.rb
@@ -4,9 +4,9 @@
 require 'psych'
 
 class KubeconfigService
-  class Invalid < StandardError
+  class InvalidKubeconfigError < StandardError
     def initialize(file_path)
-      msg = "Kubeconfig is invalid by path '#{file_path}'"
+      msg = "Invalid kubeconfig at path '#{file_path}'"
 
       super(msg)
     end
@@ -46,7 +46,7 @@ def save_to_filepath(filepath, kubeconfig)
       target_kubeconfig = File.exist?(real_file_path) ? Psych.safe_load(File.read(real_file_path)) : nil
 
       if target_kubeconfig.present? && !valid_kubeconfig?(target_kubeconfig)
-        raise Invalid.new(filepath)
+        raise InvalidKubeconfigError.new(filepath)
       end
 
       new_kubeconfig = block_given? ? yield(target_kubeconfig) : merge(target_kubeconfig, kubeconfig)

diff --git a/test/uffizzi/cli/cluster_test.rb b/test/uffizzi/cli/cluster_test.rb
@@ -156,12 +156,12 @@ def test_update_kubeconfig_if_kubeconfig_path_has_invalid_file
 
     File.write(@kubeconfig_path, kubeconfig_from_filesystem)
 
-    error = assert_raises(KubeconfigService::Invalid) do
+    error = assert_raises(KubeconfigService::InvalidKubeconfigError) do
       @cluster.update_kubeconfig
     end
 
     assert_requested(stubbed_uffizzi_cluster_get_request)
-    assert_match('is invalid', error.message)
+    assert_match('Invalid kubeconfig', error.message)
   end
 
   def test_describe_cluster