-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Windows support #42
Conversation
This is great man, thank you for doing this. I've been busy and was hoping someone else took an interest in making this happen :) |
This looks great! Thank you for taking it on :) I'll check this out soon and test it, if it's all good I'll publish it via the releases on this repo. |
@rllyy97 Thank you so much for making a PR with Windows support! I'm testing the changes now but I get the following error when I add a reply to an existing post: usePost.js:106 Error: The "path" argument must be of type string. Received an instance of Array This happens when I "Add another entry" or "Reflect". Could this be related to the path changes in the PR? Let me know if you need more info/repro steps. Thanks again! |
@UdaraJay I've cleaned up the patch file and fixed the issue brought up by @GTruss, should be good now. |
Thanks @rllyy97! the patch looks good and everything works– it'll be published after some more testing on a windows machine! The AI setup state is available from AIContext, but def a good idea to explicitly disable the reflect and embedding generation when there is no key. Your change is good for now– I'll hope to consolidate the AI APIs into one state in the future. |
Main Changes
Added Windows build support!
Builds with the NSIS windows target.
Adjustments for Windows:
pdf-parse
package that is used in thellamaindex
dependency has a bug that crashes the app when builtI'm not exactly sure how you go about publishing the packaged files, but just to test I was running
package:win
and then running the resulting setup .exe file and it all seemed to work greatScreenshots
((( If you want any more help with this project just lmk )))