[Alloyx] Phase 2 - Rebalancing IX #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-vincent
commented
Oct 30, 2023
| + u128::from(profits_beneficiary_collateral_after.amount); | ||
| assert!( | ||
| protocol_total_value_before <= protocol_total_value_after, | ||
| "protocol value loss!" |
There was a problem hiding this comment.
this test is quite powerful, ensuring we have zero loss in ALL cases
…DProtocol/uxd-program into vbrunet/2023_10_10-rebalancing-alloyx
crypto-vincent
changed the title
acamill
previously approved these changes
Nov 8, 2023
Orelsanpls
reviewed
Nov 11, 2023
programs/uxd/src/instructions/rebalance_alloyx_vault_depository.rs
Outdated
Show resolved
Hide resolved
programs/uxd/src/instructions/rebalance_alloyx_vault_depository.rs
Outdated
Show resolved
Hide resolved
acamill
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces has a few goals:
rebalance_alloyx_vault_depository(deposit to alloyx when underweight, withdraw when overweight)Note that a large portion of the diff from this PR comes from the effort to improve/expand the integration tests for rebalancing+mint+redeem.