-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to nan
Values Breaking UGRID Data Type and Fill Values
#259
Conversation
nan
Values Breaking UGRID Data Type and Fill Valuesnan
Values Breaking UGRID Data Type and Fill Values
nan
Values Breaking UGRID Data Type and Fill Valuesnan
Values Breaking UGRID Data Type and Fill Values
@erogluorhan @anissa111 @rajeeja This is a hotfix PR to the issue @hongyuchen1030 discovered in #191. Hoping we can get this merged ASAP so that it doesn't inhibit her work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fix looks good in general! Thank you for your work! Just left some little questions/comments that I am not clear with.
Documentation failing due to an issue upstream, can ignore for now (see pydata/pydata-sphinx-theme#1274) |
It looks like the sphinx-book-theme made a release last night (v1.0.1). I'd try re-running the docs without the pin now |
Overview
nan
was used forMesh2_face_nodes
, sincenp.isnan
needs to be used to locate any occurrences ofnan
test_standardized_dtype_and_fill
to separate datasets that contain a fill value and those that don't_read_ugrid
to correctly parse the original fill value_replace_fill_values
now usesnp.isnan
to find all occurrences ofnan