Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-49] Add security object with requestedAuthnContext to include password and x509 to AzureIdPs #50

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

goulter
Copy link
Contributor

@goulter goulter commented Oct 10, 2023

Change Description: Fix Azure SAML authentications for Cascadia and FHCC (not UW Tenant) not working with Identity.UW because Azure returns "X509, MultiFactor" instead of "Password protected transport"

Closes Github Issues:
GH-49

uw-saml-python Pull Request checklist

  • I have run ./scripts/pre-push.sh
  • I have selected a semver-guidance: label for this pull request (under labels,
    to the right of the screen)

If you do not do both of these things, your checks will either not run, or have a high probability of failing.

@goulter goulter marked this pull request as ready for review October 10, 2023 23:25
@goulter goulter requested review from jprosser and jdiverp October 10, 2023 23:25
Copy link
Contributor

@jprosser jprosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach but I haven't had a chance to test this myself, approving all the same as it will be tested eventually, of course.

@goulter goulter merged commit 5e28734 into main Oct 16, 2023
@goulter goulter deleted the GH-49 branch October 16, 2023 15:36
@jdiverp
Copy link
Contributor

jdiverp commented Oct 16, 2023

I haven't seen the change yet on identity-glenrg.iamdev.s.uw.edu, just now:

<samlp:RequestedAuthnContext Comparison="exact">
  <saml:AuthnContextClassRef>urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport</saml:AuthnContextClassRef>
 </samlp:RequestedAuthnContext>

@goulter
Copy link
Contributor Author

goulter commented Oct 16, 2023

I loaded the code, and the deploy was successful, so it should be there. Hmmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants