Added data structures and basic project setup. ...As well as some other things... #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madfrog54321
requested changes
Feb 18, 2017
There was a problem hiding this comment.
The header files need to moved to include folders. The sub folders can be kept, but they need their own CMakeLists file. CMakeLists should not use hard coded statements to get project files.
You can find an example set of CMakeList.txt files in the peripherals folder under BoneCentral. In that project it also has individual modules split into separate sub folders.
…nstead of absolute file references.
kylerjensen
changed the title
madfrog54321
approved these changes
Feb 24, 2017
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #180 and #185. We should probably talk through this pull request. Since I wasn't there for the rest of the meeting, I'm not sure what the rest of the design ended up as.