Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new calculation for M matrix with IEFs #324

Merged
merged 1 commit into from
Nov 1, 2024
Merged

add new calculation for M matrix with IEFs #324

merged 1 commit into from
Nov 1, 2024

Conversation

bl-young
Copy link
Collaborator

@bl-young bl-young commented Nov 1, 2024

see discussion in #323 and relates to #311

@bl-young
Copy link
Collaborator Author

bl-young commented Nov 1, 2024

@WesIngwersen @jvendries implementation of that new approach is here

@bl-young bl-young marked this pull request as ready for review November 1, 2024 13:49
@WesIngwersen WesIngwersen self-requested a review November 1, 2024 14:46
Copy link
Collaborator

@WesIngwersen WesIngwersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with v1.1c ME state model and produced expected results

@bl-young bl-young merged commit 28254f6 into develop Nov 1, 2024
6 checks passed
@bl-young bl-young deleted the M_withIEFs branch November 1, 2024 15:00
@bl-young bl-young mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants