Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC review [doc]: example not complete #73

Closed
rcaneill opened this issue May 10, 2024 · 0 comments · Fixed by #82
Closed

RC review [doc]: example not complete #73

rcaneill opened this issue May 10, 2024 · 0 comments · Fixed by #82

Comments

@rcaneill
Copy link
Contributor

"In the above we can see examples where the results were in deg F and in the result field they've been converted into degree_Celsius"

in the output they are no example of deg F, this can be fixed by adding a cell:

# Examine deg F
temperature_results.loc[df['ResultMeasure/MeasureUnitCode'] == 'deg F']
@jbousquin jbousquin linked a pull request Jul 5, 2024 that will close this issue
jbousquin added a commit that referenced this issue Jul 5, 2024
* Update README.md with badges

* Update README.md

Docs link and format issues link

* Update domains.py

TADA repo is now EPATADA to be unique for CRAN

* Update broken link

* Update Harmonize_Pensacola.Rmd

* remove full path

* Update requirements.txt

Be more specific about lowest version

* Update requirements.txt

pin older version (32 vs 64 changes for dtype)

* Update domains.py

Interesting new domain was added...

* Minor edits to text

* Fix plot

* Install from deve version not pinned release (one less thing to update)

* Resolve first error when knit locally

* Comment out some of the option 2 code so it doesn't run when knit-ing. Open to better options of how to format it as code but not always run it..

* First attempt to render the rmd in R (i.e. run the python code in R vignette)

* Update test_r.yaml

Try without renv, fixed typo.

* Update test_r.yaml

Switch from pip to conda (required of reticulate)

* Update test_r.yaml

Try setting up env using reticulate instead of conda (since conda-incubator is currently restricted)

* Update test_r.yaml

Combine install/run so env is not lost

* Update test_r.yaml

update env name

* Update test_r.yaml

Combine again without typo

* Update test_r.yaml

use miniconda_install() (note before I was setting up venv)

* Update test_r.yaml

install dev package from repo... for tests this should use the currently checked out instead, but just trying to get it working.

* Update test_r.yaml

Not sure why now it was case sensitive...

* Update test_r.yaml

pytest already check tests in test.yml, no need to run it a second time here.

* Update test_r.yaml

Skip unbutu, run all windows (conda)

* Update test_r.yaml

Trying on ubuntu again

* Update test_r.yaml

Try on older ubuntu version.

* Update test_r.yaml

bump action version up (getting warnings)

* Update test_r.yaml

Drop Ubuntu. Fix where python version is set from the matrix. Conda create with python version from matrix.

* Update test_r.yaml

Try setting var from matrix using with since it seemed to cut out 3.1* for 3.10.

* Update test_r.yaml

Try again (hoping it won't truncate python 3.1x this time.

* Update test_r.yaml

try as sting?

* Dynamic config pyproject.toml

Use dynamic to specify depends from requirements.txt. This should be more maintainable. and may resolve some of the install issues reveries were having. setuptools>=61.0 already required.

* Update test_r.yaml

Upload artifact at end to examine rendered html

* Update artifact test_r.yaml

Based on examples on repo

* Update test_r.yaml

* Update test_r.yaml

Only upload on one runner (win 3.11

* Wordsmith Harmonize_Pensacola.Rmd

Updated text to be more accurate with how reticulate can be used

* separators Harmonize_Pensacola.Rmd

No separators for list to conda

---------

Co-authored-by: Romain Caneill <[email protected]>
Co-authored-by: cristinamullin <[email protected]>

* Add masked result to show how ['ResultMeasure/MeasureUnitCode'] == 'deg F' changed. Re-ran all results to update. Closes #73

* Update contributing.rst

Adding example code for dev env. Closes #63

---------

Co-authored-by: Romain Caneill <[email protected]>
Co-authored-by: cristinamullin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant