Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect output flow for "at grid; consumption mix" #238

Open
Tracked by #202
dt-woods opened this issue Apr 22, 2024 · 2 comments
Open
Tracked by #202

Incorrect output flow for "at grid; consumption mix" #238

dt-woods opened this issue Apr 22, 2024 · 2 comments
Labels
in v2 Issues marked for inclusion in version 2

Comments

@dt-woods
Copy link
Collaborator

dt-woods commented Apr 22, 2024

The output from "at grid; consumption mix" processes is 120 V, but should be Electricity, AC, 2300-7650 V.

A little digging revealed:

  1. In run_net_trade() in __init__​​.py, "consumption mix" refers to "at grid" whilst "distribution mix" refers to "at user"; this distinction becomes important later on
  2. The former calls write_consumption_mix_to_dict(), which refers to eia_io_trading.py's olca_schema_consumption_mix() method.
  3. The olca_schema_consumption_mix() method utilizes process_dictionary_writer.py's exchange_table_creation_ref_cons() method.
  4. The exchange_table_creation_ref_cons() method uses the electricity_at_user_flow reference (from globals.py); note the disconnect between consumption mix and at user!

It appears the correct method to link with consumption mix is "exchange_table_creation_ref" in process_dictionary_writer.py.

@dt-woods
Copy link
Collaborator Author

First step: find out where olca_schema_consumption_mix is called. It be being applied to both "at user" and "at grid."

ssamkl added a commit to KeyLogicLCA/ElectricityLCI that referenced this issue Jun 13, 2024
exchange_table_creation_ref in eia_io_trading so
that at grid; consumption mix would correctly show
Electricity, AC, 2300-7650 V. -Solved issue USEPA#238
@ssamkl
Copy link

ssamkl commented Jun 13, 2024

Solved by changing exchange_table_creation_ref_cons() to exchange_table_creation_ref() in eia_io_trading as stated above

@dt-woods dt-woods added the in v2 Issues marked for inclusion in version 2 label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in v2 Issues marked for inclusion in version 2
Projects
None yet
Development

No branches or pull requests

2 participants