change build system to use Cmake #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
requested changes
Apr 25, 2023
cwsimmon
commented
Apr 25, 2023
shapiromatron
approved these changes
Apr 25, 2023
| @@ -1,4 +1,4 @@ | |||
| from pybmds import bmdscore, __version__ | |||
| from pybmds import __version__, bmdscore | |||
There was a problem hiding this comment.
we have code enforcement to standardize how code is written so it's consistent. This error was caused because the order of the imports wasn't in abc order. To fix, I ran make format and the formatter fixed it for me. You can google black, flake8, and isort for more info on our linters, though we're about to switch to the uber linter ruff that does all those and more.
src/code_base/bmds_helper.h
Outdated
| @@ -27,7 +27,8 @@ | |||
| const double BMDS_EPS = 1.0e-6; | |||
| const double BMDS_MISSING = -9999.0; | |||
| const double BMDS_QNORM = 1.959964; //bound for 95% confidence interval | |||
| const char BMDS_VERSION[32] = "2023.03.1"; | |||
| //const char BMDS_VERSION[32] = "2023.03.1"; | |||
There was a problem hiding this comment.
remove these comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated build environment to use CMake and integrated with pybind11 and pybmds. CMake builds should work for Windows, Mac, and Linux.