Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pybmds version location to root instead of pyproject.toml #50

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

shapiromatron
Copy link
Collaborator

@shapiromatron shapiromatron commented Aug 1, 2024

move the version string from the pyproject.toml to the project package root. There were bugs when trying to get the version when using an editable install of the package.


Fix unrelated bug where std::max was throwing an error in the windows build - see error log here: https://github.com/USEPA/BMDS/actions/runs/10202894684/job/28228004905#step:7:711

  D:\a\BMDS\BMDS\src\code_base\bmds_helper.cpp(4396,21): error C2589: '(': illegal token on right side of '::' [C:\Users\runneradmin\AppData\Local\Temp\tmp2u51jt9m.build-temp\Release\pybmds.bmdscore\bmdscore.vcxproj]
  D:\a\BMDS\BMDS\src\code_base\bmds_helper.cpp(4396,16): error C2062: type 'unknown-type' unexpected [C:\Users\runneradmin\AppData\Local\Temp\tmp2u51jt9m.build-temp\Release\pybmds.bmdscore\bmdscore.vcxproj]
  D:\a\BMDS\BMDS\src\code_base\bmds_helper.cpp(4396,21): error C2059: syntax error: ')' [C:\Users\runneradmin\AppData\Local\Temp\tmp2u51jt9m.build-temp\Release\pybmds.bmdscore\bmdscore.vcxproj]

@shapiromatron shapiromatron merged commit 0b559df into main Aug 3, 2024
3 checks passed
@shapiromatron shapiromatron deleted the pybmds-version-location branch August 3, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant