Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github action for windows #13

Merged
merged 52 commits into from
May 7, 2024
Merged

github action for windows #13

merged 52 commits into from
May 7, 2024

Conversation

shapiromatron
Copy link
Collaborator

@shapiromatron shapiromatron commented May 8, 2023 •
edited
Loading

Add a github action to build the python dll package for windows.

@munnsmunns
Copy link
Collaborator

https://stackoverflow.com/questions/76660368/how-to-link-libraries-installed-in-a-conda-env-to-a-c-program-using-cmake

Found some info on linking conda libraries to cmake, but I don't fully understand it

@munnsmunns munnsmunns marked this pull request as ready for review May 6, 2024 14:55
munnsmunns
munnsmunns approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge!

@munnsmunns munnsmunns merged commit eb4e7ba into main May 7, 2024
2 checks passed
@munnsmunns munnsmunns deleted the actions-windows branch May 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnsmunns munnsmunns munnsmunns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shapiromatron @munnsmunns