Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] compilation error due to isspace() in usddeck.c #1

Closed
wants to merge 1 commit into from
Closed

[FIX] compilation error due to isspace() in usddeck.c #1

wants to merge 1 commit into from

Conversation

jungr-ait
Copy link

HINT: resolves error: array subscript has type 'char'
[-Werror=char-subscripts] as all warnings are treated as errors.
This error occurs when running the build.sh script from the crazyswarm (master branch) project.

HINT: resolves error: array subscript has type 'char'
[-Werror=char-subscripts] as all warnings are treated as errors
@whoenig
Copy link

whoenig commented Jun 23, 2019

Hi,
We try to keep the crazyswarm firmware as close as possible to the official firmware. This issue exists in the official firmware and can be fixed by upgrading your compiler (see bitcraze#418). If you want to change the code anyways, I suggest that you re-open the issue in the official firmware and create a PR there. We will pick up the change for the crazyswarm during our next merge.
Thanks!

@whoenig whoenig closed this Jun 23, 2019
@jungr-ait
Copy link
Author

jungr-ait commented Jun 24, 2019

Thank you for your fast reply and the link to the issue,

I followed to official instructions and I am working with a docker container. I cannot build the container due to this error. So either we need to fix this bug or change the official documentation in case of Ubuntu 16.04 (https://crazyswarm.readthedocs.io/en/latest/installation.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants