Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM packages #981

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Update NPM packages #981

merged 6 commits into from
Oct 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Problem

Node packages need to be kept up to date.

Major Changes

List major version upgrades and any packages that caused breaking changes.

Testing/Validation

Enumerate on steps to validate the updates.

@github-actions github-actions bot requested review from a team as code owners October 16, 2024 10:12
Copy link
Contributor Author

Outdated Packages

Package Current Wanted Latest Location Depended by
@typescript-eslint/eslint-plugin 7.18.0 7.18.0 8.9.0 node_modules/@typescript-eslint/eslint-plugin functions
eslint 8.57.1 8.57.1 9.12.0 node_modules/eslint functions
eslint-plugin-n 16.6.2 16.6.2 17.11.1 node_modules/eslint-plugin-n functions
eslint-plugin-promise 6.6.0 6.6.0 7.1.0 node_modules/eslint-plugin-promise functions
mssql 10.0.4 10.0.4 11.0.1 node_modules/mssql functions
@typescript-eslint/eslint-plugin 7.18.0 7.18.0 8.9.0 node_modules/@typescript-eslint/eslint-plugin common
eslint 8.57.1 8.57.1 9.12.0 node_modules/eslint common
eslint-plugin-n 16.6.2 16.6.2 17.11.1 node_modules/eslint-plugin-n common
eslint-plugin-promise 6.6.0 6.6.0 7.1.0 node_modules/eslint-plugin-promise common
@typescript-eslint/eslint-plugin 7.18.0 7.18.0 8.9.0 node_modules/@typescript-eslint/eslint-plugin dev-tools
eslint 8.57.1 8.57.1 9.12.0 node_modules/eslint dev-tools
eslint-plugin-n 16.6.2 16.6.2 17.11.1 node_modules/eslint-plugin-n dev-tools
eslint-plugin-promise 6.6.0 6.6.0 7.1.0 node_modules/eslint-plugin-promise dev-tools
@typescript-eslint/eslint-plugin 7.18.0 7.18.0 8.9.0 node_modules/@typescript-eslint/eslint-plugin e2e
eslint 8.57.1 8.57.1 9.12.0 node_modules/eslint e2e
eslint-plugin-n 16.6.2 16.6.2 17.11.1 node_modules/eslint-plugin-n e2e
eslint-plugin-promise 6.6.0 6.6.0 7.1.0 node_modules/eslint-plugin-promise e2e
@typescript-eslint/eslint-plugin 7.18.0 7.18.0 8.9.0 node_modules/@typescript-eslint/eslint-plugin user-interface
@typescript-eslint/parser 7.18.0 7.18.0 8.9.0 node_modules/@typescript-eslint/parser user-interface
esbuild 0.23.1 0.23.1 0.24.0 node_modules/esbuild user-interface
eslint 8.57.1 8.57.1 9.12.0 node_modules/eslint user-interface

Copy link
Contributor Author

Audit Results

user-interface has npm audit findings.

@testing-library/jest-dom has an issue with an import in version 6.6.0.
testing-library/jest-dom#641
There is already a pull request to fix this, but for now we can unblock
by excluding this broken version.
Comment on lines +89 to +91
const isConflict = error.originalError
? isConflictError(error.originalError)
: isConflictError(error);
Copy link
Contributor

@jamesobrooks jamesobrooks Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some time back we wrapped up errors in the execute function on CosmosDbRepository. So here, the call to isConflictError was returning false (even when it should have been true).

"react-select": "^5.8.1"
},
"devDependencies": {
"@testing-library/jest-dom": "^6.5.0",
"@testing-library/jest-dom": ">6.4.8 <6.6.0 || >6.6.0 <7.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with an open PR to fix a problem with version 6.6.0.

Copy link
Contributor

@fmaddenflx fmaddenflx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.

@jamesobrooks jamesobrooks merged commit 63e53e4 into main Oct 16, 2024
28 checks passed
@jamesobrooks jamesobrooks deleted the dependency-updates-auto branch October 16, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants