Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui module #327

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Update ui module #327

merged 3 commits into from
Mar 25, 2024

Conversation

slesaad
Copy link
Collaborator

@slesaad slesaad commented Mar 19, 2024

What am I changing and why

Update UI module to the latest main at commit 8804ee30025bd81cdc841e8c1d22d94d7eb4675a

  • Fixes y label in time-series chart

How to test

  • Manually validated

⚠️ Checks

@slesaad slesaad requested a review from sandrahoang686 March 19, 2024 18:30
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for ghg-demo ready!

Name Link
🔨 Latest commit 3c94e68
🔍 Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/6601c406735cac00089a5ac0
😎 Deploy Preview https://deploy-preview-327--ghg-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slesaad
Copy link
Collaborator Author

slesaad commented Mar 19, 2024

@sandrahoang686 @hanbyul-here anything i need to look an eye out for with this?

@sandrahoang686
Copy link
Collaborator

@slesaad is this so you can pull in changes from this PR here? I would just manually validate the deploy preview to see that no unexpected behaviors are happening, otherwise all AE changes we have been pushing should still be flagged 👍🏼

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Mar 20, 2024

How urgent does this need to go out? It will be ideal if we can actually use the versioned UI so we have a better track of which instance using what version of UI.

@slesaad
Copy link
Collaborator Author

slesaad commented Mar 20, 2024

@hanbyul-here i was planning to get it out today, but can wait if there's gonna be a release by friday. there's another fix in the analysis page that needs to go out soon. let me know!

@hanbyul-here
Copy link
Collaborator

It seems like a good time to cut a release on UI: NASA-IMPACT/veda-ui#895 Unless we see a critical problem, let's use this v4.2

@slesaad slesaad merged commit 7958aa9 into develop Mar 25, 2024
5 checks passed
@slesaad slesaad deleted the update-ui-module branch March 25, 2024 18:38
@slesaad slesaad mentioned this pull request Mar 25, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants