Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S1 - T5 feature/enemies #49

Merged
merged 48 commits into from
Sep 1, 2021
Merged

S1 - T5 feature/enemies #49

merged 48 commits into from
Sep 1, 2021

Conversation

yourlow
Copy link
Contributor

@yourlow yourlow commented Sep 1, 2021

Enemies Feature, at a glance

3 enemies added: Long Range, Small enemy, Large enemy

files added:

BulletFactory: for creating bullets
BulletCollider: collider component for bullets
DistanceFireBulletTask: ai task 'fire bullet at enemy within a certain radius'
FireBulletTask: simpler implementation of DistanceFireBulletTask
FireBulletListener: component for listening to the ai FireBulletTask's

files Changed:

NPCFactory: Extensive changes, added factories for the 3 enemies
ForestGameArea: added spawning functions for the 3 enemies
TextureRenderComponent: changed draw function to add rotation capability to texture components

PhysicsEngine: changed how physics bodies are being destroyed (the game will crash without this)
ColliderComponent add to comment out the destruction of fixtures
For reasoning behind these last two changes refer to this issue on the game engine UQdeco2800/game-engine#8

also added all assets for the enemies

note: going to keep T5 but it really should be T3, you can blame @yourlow for this tragedy

yourlow and others added 30 commits August 19, 2021 18:32
projectiles are now removed on collsion with the player
 NPC factory refactor PhysicsMovementComponent addition from base entity to child entities
 NPC factory refactor PhysicsMovementComponent addition from base entity to child entities
…factory refactor PhysicsMovementComponent addition from base entity to child entities
…d the methods relating to ghost and ghost king to clean up the code.
added a distance based bullet AI task
Copy link
Contributor

@Bluehalomango Bluehalomango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh, this merge adds and changes a fair bit of stuff... Do you mind adding a description to your request to go over the main stuff, particularly what you've changed with other files? Otherwise it'll be tricky to check everything.

@25Ericcheong
Copy link
Contributor

Might be worth pulling main into your feature branch first and solving the conflicts locally before creating a pull request I believe. Just had a look at your commits, main hasn't been merged into your feature branch since we started working on the project.

@SpiritBlues7
Copy link
Contributor

Enemies seem to work well, I like that they all look distinct so that it is easy to tell them apart. As other comments have mentioned: should add a description and fix merge conflicts before merging the pull request.

@yourlow yourlow changed the title S1 t5 feature/enemies S1 - T5 feature/enemies Sep 1, 2021
Copy link
Contributor

@Bluehalomango Bluehalomango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Seem to have a few inconsistencies with formating and styling (i.e. a bunch of the files changed just seem to be from identation) but its hard to tell how that looks here. Should be fine though.

@yourlow
Copy link
Contributor Author

yourlow commented Sep 1, 2021

There's some quite bad breaking changes with merging this branch with the current main branch (mainly our interactions with the player) going to fix them in this merge!

integrated playerattack with enemies,
increased speed of player bullets (for fun!)
increased speed of player bullets
@yourlow yourlow merged commit a62b03b into main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants