added verify and relative test #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makapx
requested changes
Nov 8, 2023
GiuseppeBnn
commented
Nov 8, 2023
simone989
reviewed
Nov 9, 2023
| fail_test_array = range(35,100) | ||
| import src.verify as verify | ||
|
|
||
| def test_verify(): |
There was a problem hiding this comment.
Rinomina la funzione, leggendo la firma del metodo non è chiaro cosa stai testando.
simone989
reviewed
Nov 9, 2023
| assert verify.is_element_in_list(i) == True | ||
| for i in fail_test_array: | ||
| if i not in success_test_array: | ||
| assert verify.is_element_in_list(i) == False |
There was a problem hiding this comment.
Cosa te ne pare di definire due funzioni separate? Una che testa solo i casi positivi e una solo i casi negativi.
Poi nel tuo metodo principale chiami entrambi.
simone989
reviewed
Nov 9, 2023
|
|
||
| def test_verify(): | ||
| for i in success_test_array: | ||
| assert verify.is_element_in_list(i) == True |
There was a problem hiding this comment.
== True è superfluo.
Puoi usare
assert verify.is_element_in_list(i)
assert not verify.is_element_in_list(i)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added verify exercise in src folder and relative test.
The test cover positive cases and negative cases.