-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to BIDS 1.9 #301
Update to BIDS 1.9 #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
version should be bumped to 3.1.2
-
Love the colored output! Maybe a fully custom color formatter would standardize outputs such as described in https://alexandra-zaharia.github.io/posts/make-your-own-custom-color-formatter-with-python-logging/ ?
-
Would be cool if the container was automatically added to dockerhub through a GHA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is working for me.
However, note that when Python raise
s errors, the traceback and the error are not colored. I don't think this should keep this PR from being merged but we may want to open an issue to fix this in the future.
Nice update that should fix #300, #298, #272 and #294
I should have split this into at least two PRs but everything felt so smooth while coding 🫶