Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch all descriptions: id list #283

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Fetch all descriptions: id list #283

merged 2 commits into from
Dec 2, 2023

Conversation

arnaudbore
Copy link
Contributor

Fix #282

@arnaudbore arnaudbore requested a review from bpinsard October 25, 2023 03:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0819eeb) 75.25% compared to head (b455cc4) 75.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   75.25%   75.44%   +0.18%     
==========================================
  Files          15       15              
  Lines        1079     1079              
  Branches      239      240       +1     
==========================================
+ Hits          812      814       +2     
+ Misses        220      219       -1     
+ Partials       47       46       -1     
Flag Coverage Δ
pytest 75.44% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arnaudbore arnaudbore requested a review from SamGuay November 28, 2023 18:10
Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local data, works as expected, even with multiple runs of the same sequences (adds all of them in the IntendedFor field.

@arnaudbore arnaudbore merged commit 4955ac5 into master Dec 2, 2023
@arnaudbore arnaudbore deleted the fix_issue_282 branch March 8, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidecar_changes do not fetch all matches of the referenced description
3 participants