Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in scaffold files #263

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

SamGuay
Copy link
Member

@SamGuay SamGuay commented Sep 12, 2023

As soon as a participant sub-* directory is added, the validator will do its job and validate the dataset and won't trigger errors in the files generated by dcm2bids_scaffold.

Though, two warnings should come up, which is good as people need to fill these up:

Warning 1: [Code 102] TOO_FEW_AUTHORS
Click here for more information about this issue
The Authors field of dataset_description.json should contain an array of fields - with one author per field. This was triggered based on the presence of only one author field. Please ignore if all contributors are already properly listed.

Warning 2: [Code 115] EMPTY_DATASET_NAME
Click here for more information about this issue
The Name field of dataset_description.json is present but empty of visible characters.

Closing #254

@arnaudbore arnaudbore self-requested a review September 12, 2023 15:51
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore merged commit bc77eae into UNFmontreal:master Sep 12, 2023
@SamGuay SamGuay deleted the fix_scaffold_files branch August 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants