Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Refactorisation - Major API upgrade #200

Merged
merged 14 commits into from
Jun 8, 2023

Conversation

arnaudbore
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Merging #200 (477f00a) into master (3b773a7) will increase coverage by 9.14%.
The diff coverage is 71.09%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   67.75%   76.90%   +9.14%     
==========================================
  Files           9       15       +6     
  Lines         673      775     +102     
  Branches      102      109       +7     
==========================================
+ Hits          456      596     +140     
+ Misses        186      147      -39     
- Partials       31       32       +1     
Flag Coverage Δ
pytest 76.90% <71.09%> (+9.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/utils/logger.py 80.00% <ø> (ø)
dcm2bids/utils/args.py 39.13% <39.13%> (ø)
dcm2bids/utils/tools.py 45.94% <45.94%> (ø)
dcm2bids/cli/dcm2bids_helper.py 62.50% <50.00%> (ø)
dcm2bids/utils/io.py 67.64% <67.64%> (ø)
dcm2bids/utils/utils.py 68.75% <68.75%> (ø)
dcm2bids/cli/dcm2bids.py 77.77% <77.77%> (ø)
dcm2bids/dcm2bids_gen.py 73.72% <84.61%> (ø)
dcm2bids/version.py 87.50% <87.50%> (+41.55%) ⬆️
dcm2bids/cli/dcm2bids_scaffold.py 93.10% <93.10%> (ø)
... and 5 more

@arnaudbore arnaudbore requested a review from SamGuay June 7, 2023 02:32
@arnaudbore arnaudbore mentioned this pull request Jun 7, 2023
Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of suggestion that should fix a couple of bugs. Should be good after.

dcm2bids/utils/tools.py Outdated Show resolved Hide resolved
dcm2bids/utils/tools.py Outdated Show resolved Hide resolved
dcm2bids/utils/tools.py Outdated Show resolved Hide resolved
dcm2bids/utils/utils.py Outdated Show resolved Hide resolved
dcm2bids/cli/dcm2bids.py Show resolved Hide resolved
dcm2bids/utils/scaffold.py Outdated Show resolved Hide resolved
dcm2bids/utils/scaffold.py Outdated Show resolved Hide resolved
dcm2bids/utils/scaffold.py Outdated Show resolved Hide resolved
dcm2bids/utils/scaffold.py Outdated Show resolved Hide resolved
dcm2bids/utils/args.py Outdated Show resolved Hide resolved
@arnaudbore arnaudbore merged commit 40a7605 into UNFmontreal:master Jun 8, 2023
@arnaudbore arnaudbore deleted the enh_refactor branch June 8, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants