Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chapter 4 content #15

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Add chapter 4 content #15

merged 4 commits into from
Jul 10, 2024

Conversation

ClaireHoffmann
Copy link
Collaborator

Addresses #7.

@ClaireHoffmann ClaireHoffmann marked this pull request as draft June 26, 2023 13:02
@ClaireHoffmann
Copy link
Collaborator Author

ClaireHoffmann commented Jun 26, 2023

Hello!

I haven't changed much compared to the software carpentry version for now, I only added a few 'call out' boxes.

Also, I am wondering whether we should keep the Dracula and planets story or should we use more classic names like my_project, etc.? I see that for chapter 3, we dropped it, whereas chapter 5 still has it.

@kateburnettisaacs
Copy link
Collaborator

I agree that we should make the project names a little more generic. I'm wondering if we should make the project refer to the inflammation data/work found in the R and Python courses. What do you think?

@kateburnettisaacs
Copy link
Collaborator

Hi @ClaireHoffmann can you ask me to review this pull request so I can accept it?

@thoughthollow thoughthollow marked this pull request as ready for review July 10, 2024 14:46
@thoughthollow thoughthollow merged commit 19d7d68 into gh-pages Jul 10, 2024
@thoughthollow thoughthollow deleted the ch4 branch July 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants