-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all the Markdown files for the S24 running of this lab #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kklamberty and I decided that since we now have all these automatic checks in places, the badges aren't really necessary since the green check or red x tells us what we want/need to know. Including and updating the badges does add a little friction, so we'll just remove them. The other changes were fixing an out-of-date link and a grammar mistake.
There are quite a lot of changes here, where I wrote up the stuff about Personal Access Tokens (PATs). I hope I got all this right; it seemed to work when I ran through it on my own. I also added several screenshots and made various minor edits.
It looks like pretty much everyone has moved to using `main`, so I don't think we need this historical note anymore.
I found I couldn't push from GitKraken on the new organization, and it was because GitKraken hadn't been given permissions on that organization yet. I added that to the faculty/TA setup checklist.
This attempts to document the new merge queue approach in GitHub. I hope this makes things go more smoothly in class tomorrow! I also changed some of the notes to use the new-ish `git switch` command, which I find a lot more intuitive than `git checkout`. I added several screen grabs that will hopefully make things easier to follow.
A variety of mostly minor changes, updates, and corrections to the the Markdown files in the `docs` folder.
NicMcPhee
added
enhancement
documentation
Issues related to write-ups and documentation
labels
Jan 16, 2024
kklamberty
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny typos; otherwise looks great!
Thanks to @kklamberty for the really careful read through!
Thanks for the careful read through. Both of those are now fixed! |
kklamberty
approved these changes
Jan 16, 2024
auto-merge was automatically disabled
January 16, 2024 05:24
Merge queue setting changed
NicMcPhee
removed this pull request from the merge queue due to the queue being cleared
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot here, so this is going to be a kind of annoying PR to review. The highlights:
git
work described in part one.main
as I think that transition is mostly done now and people are a lot less likely to run into the old approach.There were also a bunch of minor grammar fixes, updates, etc. I even found one dangling reference to IntelliJ IDEA, which I switched to VS Code. 😜
Closes #118