Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AJV to validate User JSON when getting a User by ID #1464

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Use AJV to validate User JSON when getting a User by ID #1464

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ba3cf8
Add `ajv` as an `npm` dependency
NicMcPhee Jan 21, 2024
b7da181
Add `strictNullChecks` to `tscofig.json`
NicMcPhee Jan 21, 2024
c1acc84
Add schemas to `User` and `UserRole`
NicMcPhee Jan 21, 2024
47490de
Validate JSON received by `getUserById` is a `User`
NicMcPhee Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add strictNullChecks to tscofig.json 
This is necessary to get AJV to work so it can "tell the difference" between required and optional fields in a type definition.
@NicMcPhee
NicMcPhee committed Jan 21, 2024
commit b7da18134e75bf3fb6263e50545bbe709444bcb4
5 changes: 4 additions & 1 deletion client/tsconfig.json
View file
Original file line number Diff line number Diff line change
@@ -15,7 +15,10 @@
"es2020",
"dom"
],
"useDefineForClassFields": false
"useDefineForClassFields": false,
"strictNullChecks": true,
// "strict": true,
"noImplicitAny": true
},
"exclude": ["./cypress.config.ts"],
"angularCompilerOptions": {