Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment variable handling #99

Open
ChandlerSwift opened this issue Jun 21, 2020 · 0 comments
Open

Fix environment variable handling #99

ChandlerSwift opened this issue Jun 21, 2020 · 0 comments

Comments

@ChandlerSwift
Copy link
Member

Improperly entered environment variables cause parsing of attacks to fail---not on upload, but on displaying and running.

Instead of implementing our own parsing, we could consider using the parser in https://github.com/theskumar/python-dotenv (or copying it out, if we don't need the library's extra functionality).
ChandlerSwift added a commit that referenced this issue Jun 21, 2020
@ChandlerSwift
Add error handling for badly formatted env vars
324691a 
When no `=` is present in a line (including blank lines, which shouldn't
cause issues), the parser fails to split on `=` and throws an error.
This simply adds a try-catch around that to ignore values that would
fail.

This is a stopgap fix for #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChandlerSwift