Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import devices from csv into database, tesobjects in ldap_objects -> not final #16

Merged
merged 33 commits into from
Oct 21, 2024
Merged

import devices from csv into database, tesobjects in ldap_objects -> not final #16

merged 33 commits into from
Oct 21, 2024

Conversation

Dan1elRoos
Copy link
Collaborator

No description provided.

@Dan1elRoos Dan1elRoos linked an issue Aug 7, 2024 that may be closed by this pull request
Implement Device Validation for Import Process #15
Closed
@Dan1elRoos
Update test_device_page.py
485c74a 
Possible option to fix failed Tests, assertQuerysetEqual() is deprecated in favor of assertQuerySetEqual(), switched both functions
weidenba
weidenba requested changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@weidenba weidenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add some unit tests. Furthermore, there are some minor improvements regarding code readability that should be changed. Have a look at the single comments.

src/setup_scripts/__init__.py Outdated Show resolved Hide resolved
src/setup_scripts/ldap_objects.csv Outdated Show resolved Hide resolved
src/setup_scripts/db_import.py Outdated Show resolved Hide resolved
src/setup_scripts/db_import.py Outdated Show resolved Hide resolved
src/setup_scripts/db_import.py Outdated Show resolved Hide resolved
src/setup_scripts/db_import.py Outdated Show resolved Hide resolved
Dan1elRoos and others added 22 commits August 14, 2024 07:41
@Dan1elRoos
adding setup and config files
48b649c
@Dan1elRoos
added helper-functions, changed Modulname import for test_device_page
2d84b37
@Dan1elRoos
Merge main to current local branch
d3147a9
@Dan1elRoos
Fix Whitespace issues
e41df1b
@Dan1elRoos
Merge branch '15-validation-for-all-device-attributes-in-validationpy…
a31924f 
…' of https://github.com/UKB-IT-Sec/NAC-Service-Portal into 15-validation-for-all-device-attributes-in-validationpy
@Dan1elRoos
Revert "import devices from csv into database, tesobjects in ldap_obj…
931a5a0 
…ects -> not final"

This reverts commit d9a16cd.
@Dan1elRoos
Fixing static Testvariables, minor changes for CommandClass
2eb9c55
@Dan1elRoos
fixed flake8, testcoverage at 100
382f906
@Dan1elRoos
fixing inconsistent code
5c3f4f9
@Dan1elRoos
fixed syntaxerror for django ci checks
1a1b285
@Dan1elRoos
fixed minor error
c98df61
@Dan1elRoos
fix minor errors, improve compatibility
cda3dc4
@Dan1elRoos
rename
867ef99
@Dan1elRoos
remove unnecessary test-resources
1fb125d
@Dan1elRoos
Merge branch '19-deviceroleprod-equals-security-group' into 15-valida…
efa6fbb 
…tion-for-all-device-attributes-in-validationpy
@Dan1elRoos
adjust import script to DeviceRoleProd, parameterize area attribute
d83a952
@weidenba
Merge branch 'main' into 15-validation-for-all-device-attributes-in-v…
8a7deec 
…alidationpy
@Dan1elRoos
Merge branch '21-app-nac-deviceroleinst-selector' into 15-validation-…
49e7fdd 
…for-all-device-attributes-in-validationpy
@Dan1elRoos
Merge branch '21-app-nac-deviceroleinst-selector' into 15-validation-…
d4de23c 
…for-all-device-attributes-in-validationpy
@Dan1elRoos
adjust device attributes, add attribute validation
a4e2611
@Dan1elRoos
Merge branch 'main' of https://github.com/UKB-IT-Sec/NAC-Service-Portal…
423d9d9 
… into 15-validation-for-all-device-attributes-in-validationpy
@Dan1elRoos
fix flake8
dec7fc6
@weidenba weidenba self-requested a review September 16, 2024 11:50
weidenba
weidenba requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@weidenba weidenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

src/helper/filesystem.py Outdated Show resolved Hide resolved
src/nac/management/commands/import_devices.py Outdated Show resolved Hide resolved
src/nac/management/commands/import_devices.py Outdated Show resolved Hide resolved
src/nac/management/commands/import_devices.py Outdated Show resolved Hide resolved
src/nac/management/commands/import_devices.py Outdated Show resolved Hide resolved
src/nac/management/commands/import_devices.py Outdated Show resolved Hide resolved
@weidenba
Copy link
Collaborator

weidenba commented Oct 2, 2024

grafik
The import script should check if an entry already exists. otherwise some strange stuff could happen. I think it would be best, if a command line switch controls if a device gets updated or if the add operation should fail.

@weidenba weidenba merged commit 7a72c6f into main Oct 21, 2024
4 checks passed
@weidenba weidenba deleted the 15-validation-for-all-device-attributes-in-validationpy branch October 21, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidenba weidenba weidenba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Device Validation for Import Process
2 participants
@Dan1elRoos @weidenba