Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIM-608): gov notify - file upload/link support #1083

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ttbarnes
Copy link

@ttbarnes ttbarnes commented Dec 6, 2024

Introduction ✏️

GOV Notify integration needs the ability to consume and send a file buffer, in order for users to be able to download a file stored securly by Notify.

Resolution ✔️

  • Update GOV Notify constants.
  • Update GOV Notify service to conditionally add a linkToFile property.
  • Update PostEmailsRequestDto module to include FILE.
  • Create new mock JSON response (for unit tests).

Miscellaneous ➕

  • Minor JSON indentation improvement.
  • Minor documentation improvment.

@ttbarnes ttbarnes self-assigned this Dec 6, 2024
@ttbarnes ttbarnes changed the title feat(APIM-608): gov notify - file link support feat(APIM-608): gov notify - file upload/link support Dec 6, 2024
Copy link

sonarcloud bot commented Dec 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant