-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary installers now available on Pip #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary installers for Pandana are now available on Pip! 🎉
Works on Linux, Mac, and Windows, with Python 3.5 through 3.9.
Background: Conda Forge builds binary installers through a centralized system, but PyPI requires package authors to do it. We never had a smooth workflow for this, and switched at some point to just providing source builds on Pip because it was easier.
But now we can do it using GitHub Actions!
Changes
This PR adds a workflow script for generating the wheels. It will run when PRs are opened, to confirm nothing is broken, and again when a release is tagged. The resulting wheel files can be downloaded from GitHub and posted to PyPI in the same manner as the source builds (see CONTRIBUTING.md).
Installation instructions are updated in the GitHub README and in the Sphinx docs (see here)
Release instructions are updated in CONTRIBUTING.md
Moves test coverage reporting internal (an actions script + bot will now report it in the PR thread) in response to a Coveralls integration glitch
no changes to code
Deployment
I already updated the live copy of the docs: http://udst.github.io/pandana/
Binary installers for Pandana v0.6 have been posted to PyPI. I'll wait about a week to see if anyone reports issues, and then post binaries for v0.5.1 and v0.4.4 as well.