Require C++11 #155
Merged
Require C++11 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicofernandez
approved these changes
Dec 29, 2020
julianpalladino
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes accommodations for pre-C++11 compilers, to streamline compilation on newer systems and allow us to use C++11 features.
I believe we tried to do this earlier in the v0.4 release, but had to backpedal in order to continue building Pandana for Windows Python 2.7 environments. Now that we no longer support Python 2.7, we can go ahead with requiring C++11.
Changes:
accessibility.cppfrom PR Remove code that requires C++11 features #123POIIndex.h(TR1 was the precursor to the C++11 standard)Testing:
Anything else we should include or test?