Compilation fixes for MacOS 10.15 Catalina #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
setup.py
in order to support Pandana compilation in MacOS 10.15 Catalina, as discussed in issue #129. The system's C++ headers were moved, so the script now detects which version of the operating system is present and uses the appropriate header path. This PR also improves support for custom compilers on Mac.New usage
Installing Pandana from Conda Forge gives you pre-compiled binaries. Installing from Pip or from source code requires local compilation. (Pip binaries are a lot harder for us to provide than Conda Forge binaries, so we had to drop them.)
Here's how local compilation works on Mac:
All Macs will need Xcode command line tools in order to do the local compilation.
At this point, you can do one of the following:
CC
environment variable, and if so we use whichever compiler you specify.Testing
CC
set manually