-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Enhancements #2089
Open
parthshindee
wants to merge
35
commits into
UCSD:experimental
Choose a base branch
from
parthshindee:experimental
base: experimental
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Performance Enhancements #2089
Changes from 33 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f13f384
implemented cached network image
klortiz13 1087f7b
finished implementing imagecacheloading
klortiz13 ae9de03
fixed some small ui
klortiz13 93f76e2
cached the image of events, scanner, and myCHart
klortiz13 6ef2b92
Merge pull request #1 from parthshindee/kristhian-cached-image-packag…
parthshindee 542be64
implemented ListView.builder in the media card. Also removed unused v…
klortiz13 e8dc7db
implemented listview builder in weather card
klortiz13 87bc706
implemented cachedNetworkImage to weather card
klortiz13 0fd24ca
implemented cache image to student id
klortiz13 e0314ae
implemented pageView.builder in shuttle card
klortiz13 0cbe57b
implemented pageVIew.builder in parking card
klortiz13 b763805
implemented cached image to notices card
klortiz13 8f25540
implemented listview builder to the news card and imageLoader to the …
klortiz13 0cfa9e2
fixed employee_id card and finals card
klortiz13 476b0d3
resized shuttle card
klortiz13 22f634f
implemented lazy loading in dinning card
klortiz13 d31b64f
fixed loading indicator in student id
klortiz13 81d6991
fixed loading indicator in wheather card
klortiz13 ad3e7f2
fixed media card
klortiz13 a9bdade
implemented listview builder in classes card
klortiz13 84647ec
implemented list view builder in availability display .dart
klortiz13 d88a86f
refactored availability detail view to implement listview builder
klortiz13 2ac5e20
implemented pageview builder in availability card
klortiz13 ee3e22d
Merge pull request #2 from parthshindee/kristhian-lazy-loading
klortiz13 6bee42b
converted student_id_card into a stateless widget card
klortiz13 aec972a
converted employee id to stateless
klortiz13 f69db57
fixed typo in student id card
klortiz13 cef26c6
Merge pull request #3 from parthshindee/kristhian-stateless-conversion
klortiz13 e59a1ad
merged with upstream
klortiz13 038a06e
updated
parthshindee b39a732
updated
parthshindee 21ea0a4
Merge remote-tracking branch 'origin/experimental' into experimental
parthshindee 144ea70
updated
parthshindee f52041a
updated pubspeck
parthshindee bf1657a
pulled from upstream
parthshindee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell if this is proper usage of functional-style iterator methods. Let's try to rework this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parthshindee let's meet on this one individually to see the best solution. Possible precedent case for the official Campus Mobile Style Guide