Frontend ui #4
Open
Frontend ui #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Establish a connection | ||
| @connection = nano([url, @query and "?" + @query].join("")) | ||
|
|
||
| _.extend Miso.Importers.Couchdb::, |
There was a problem hiding this comment.
might want to explicitly say .prototype just to be clear.
There was a problem hiding this comment.
Actually I don't need to use these anymore ever since I switched from miso dataset to google
|
|
|
|
||
| esPort = 22 | ||
| esUser = process.env['EC2_ES_SSH_USER'] | ||
| esUser = cfg.EC2_ES_SSH_USER | ||
|
|
||
| stageDBLoadAvg = "" |
There was a problem hiding this comment.
stage:
db:
mem:
total: ""
free: ""
load: ""Also why initialize these as strings if we're going to assign floats to them later?
There was a problem hiding this comment.
Careless mistake. Will fix when I get back.
|
Pretty much a shitton of copy paste code. I wanted to get it working first then i'll refactor it. |
|
Address @jenrzzz's comments and let's get this in on Wednesday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Kthx.