Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIGS page #305

Merged
merged 26 commits into from
Mar 5, 2024
Merged

Add SIGS page #305

merged 26 commits into from
Mar 5, 2024

Conversation

Trek182021
Copy link
Contributor

@Trek182021 Trek182021 commented Feb 15, 2024 •
edited
Loading

Note: This PR should only be merged after noelle/nextui branch is merged

Summary

This PR aims to create the SIGS page based on the old website design.

  • Created SIGS page
  • Created the following components: SigTopic, SectionTitle
  • Added table in SIG topic instead of a video and description.

Types of changes

What types of changes does your code introduce to the UC Merced's ACM Chapter Website?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • Lint, format, and unit test workflows pass with my new changes
  • This PR does not address a duplicate issue or PR
Changes Preview

Screenshot 2024-02-14 at 20-52-17 Vite React TS

No767 and others added 20 commits December 30, 2023 19:24
@No767
[skip ci] Clean up assets and include ACM logo
3f8252e
@No767
Introduce NextUI
0a37848
@No767
Implement global navbar and start working on front page
c81540e
@No767
Implement global navbar and start working on front page
dd63871
@No767
Work on front pages
b92bdc4
@No767
Fix prev commit
f4bb344
@No767
Upgrade to yarn 4 + merge from react-rewrite
8c5041f
@No767
Relock yarn modules
4cb23f8
@No767
Remove unused components
6d4d02f
@No767
Add a basic footer
cce91a1
@No767
Merge from react-rewrite
daec67a
@No767
The website is finally coming along
9b64fea
@No767
Format
80b33c6
@No767
Add footer icons
1b3947a
@No767
Redo the lock files
d79f476
@No767
Merge and lock
1e74d75
@No767
Merge n lock
eb5312b
@No767
Merge and lock from main
5973b84
@No767
Adjust the padding around goals
cc2bb24
@Trek182021
Add SIGS page
7373f64 
Page:
- Created SIGS page

Component:
- Created SectionTitle
- Created SigTopic (SIG title, description, and events table)
@Trek182021 Trek182021 requested a review from No767 February 15, 2024 04:52
@Trek182021 Trek182021 self-assigned this Feb 15, 2024
@Trek182021 Trek182021 marked this pull request as draft February 15, 2024 04:54
@Trek182021 Trek182021 marked this pull request as ready for review February 15, 2024 05:50
@Trek182021 Trek182021 linked an issue Feb 15, 2024 that may be closed by this pull request
Build SIGs Page #279
Closed
3 tasks
@No767
Copy link
Member

No767 commented Mar 1, 2024

@Trek182021 you might want to force push changes from react-rewrite and clean up merge conflicts as needed. once that is done, i'll start reviewing the pr

@netlify Netlify
Copy link

netlify bot commented Mar 1, 2024 •
edited
Loading

❌ Deploy Preview for ucmacm failed.

Name Link
🔨 Latest commit 4ef5ac7
🔍 Latest deploy log https://app.netlify.com/sites/ucmacm/deploys/65e6d4caf233680008cc29bd

No767
No767 reviewed Mar 5, 2024
View reviewed changes
react/ucmacm-website/src/index.css
@@ -1,3 +1,7 @@
/* Temporary fonts based on old website */
@import url('https://fonts.googleapis.com/css2?family=Bebas+Neue&family=Montserrat&display=swap');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a way to do it in tailwindcss but this is fine for now

No767
No767 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@No767 No767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll add the routers for this later today if i can

@No767 No767 merged commit 301cd0e into react-rewrite Mar 5, 2024
2 of 6 checks passed
@No767 No767 deleted the julian/sigs branch March 5, 2024 08:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@No767 No767 No767 approved these changes

Assignees

@Trek182021 Trek182021

Labels
components
Projects
No open projects
Chapter Website Rewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build SIGs Page
2 participants
@Trek182021 @No767