[SERV-909] Update metadata updating #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRickard
reviewed
Mar 20, 2024
src/main/java/edu/ucla/library/iiif/fester/verticles/V2ManifestVerticle.java
Show resolved
Hide resolved
DRickard
approved these changes
Mar 20, 2024
angelahuqing
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the manifest didn't have any metadata we didn't update it, but this commit changes that so that new metadata fields are added even if there aren't any pre-existing metadata fields in the record.
I also turned down logging on the presentation library's attempt to derive a media type from the URL since not all URLs have file extensions on them. This is something that should probably be fixed upstream too, fwiw.