Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERV-889] Handle "IIIF Parent ARK" Header in CSVs #235

Merged
merged 8 commits into from
Dec 1, 2023
Merged

[SERV-889] Handle "IIIF Parent ARK" Header in CSVs #235

merged 8 commits into from
Dec 1, 2023

Conversation

DRickard
Copy link
Member

  • Add new column to CSV.java
  • Add get/set/verify for new column in CsvHeaders.java
  • Add logic to give precedence to new column in CsvParser.java
  • Tests for handling new column

@DRickard DRickard added the enhancement An improvement to an existing feature label Nov 30, 2023
@DRickard DRickard self-assigned this Nov 30, 2023
@DRickard DRickard marked this pull request as ready for review November 30, 2023 19:53
@DRickard DRickard requested a review from a team as a code owner November 30, 2023 19:53
@ksclarke
Copy link
Member

I set Codacy to ignore the same issue we decided to ignore with the other PR.

@DRickard DRickard merged commit 2ee3edd into main Dec 1, 2023
3 checks passed
@DRickard DRickard deleted the SERV-889 branch December 1, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelahuqing angelahuqing angelahuqing approved these changes

@ksclarke ksclarke ksclarke approved these changes

Assignees

@DRickard DRickard

Labels
enhancement An improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DRickard @ksclarke @angelahuqing